Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update variable group names to target new subscription #6197

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update variable group names to target new subscription #6197

wants to merge 2 commits into from

Conversation

mthalman
Copy link
Member

@mthalman mthalman commented Feb 4, 2025

Updates the variable names to target the new Azure subscription.

@mthalman mthalman added the do-not-merge A PR that should not be merged yet but needs to remain open label Feb 4, 2025
@mthalman mthalman requested a review from a team as a code owner February 4, 2025 14:43
@lbussell
Copy link
Contributor

lbussell commented Feb 4, 2025

Looks like the image info file is not making it through to the tests. There should be lots of --path arguments passed here: https://dev.azure.com/dnceng-public/public/_build/results?buildId=940112&view=logs&j=fc59f0f2-c1bd-58ae-b870-833d1e8a924c&t=42b16712-47b7-5d4e-b8e4-5c4616c57a47&l=51

@lbussell
Copy link
Contributor

lbussell commented Feb 5, 2025 •
edited
Loading

Also, this other PR is encountering the same issue: #6203

It doesn't seem to be specific to any changes you made in this PR.

@mthalman
Copy link
Member Author

mthalman commented Feb 5, 2025

Also, this other PR is encountering the same issue: #6203

It doesn't seem to be specific to any changes you made in this PR.

It's also happening in nightly: #6198

@mthalman
Copy link
Member Author

mthalman commented Feb 5, 2025

Looks like the image info file is not making it through to the tests. There should be lots of --path arguments passed here: https://dev.azure.com/dnceng-public/public/_build/results?buildId=940112&view=logs&j=fc59f0f2-c1bd-58ae-b870-833d1e8a924c&t=42b16712-47b7-5d4e-b8e4-5c4616c57a47&l=51

Image info file is not supposed to be set. That gets set here:

dotnet-docker/eng/common/templates/steps/test-images-linux-client.yml

Lines 24 to 29 in f528525

if [ "${{ variables['System.TeamProject'] }}" == "${{ parameters.internalProjectName }}" ] && [ "${{ variables['Build.Reason'] }}" != "PullRequest" ]; then
additionalTestArgs="$additionalTestArgs -PullImages -Registry $(acr-staging.server) -RepoPrefix $(stagingRepoPrefix) -ImageInfoPath $(artifactsPath)/image-info.json"
if [ "$TESTCATEGORIESOVERRIDE" != "" ]; then
additionalTestArgs="$additionalTestArgs -TestCategories $TESTCATEGORIESOVERRIDE"
fi
fi

It would only happen on internal builds.

And the paths are being set here: https://dev.azure.com/dnceng-public/public/_build/results?buildId=940112&view=logs&j=fc59f0f2-c1bd-58ae-b870-833d1e8a924c&t=42b16712-47b7-5d4e-b8e4-5c4616c57a47&l=12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge A PR that should not be merged yet but needs to remain open
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mthalman @lbussell